Skip to content

[Merged by Bors] - feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence.#27837

Closed
CBirkbeck wants to merge 14 commits intoleanprover-community:masterfrom
CBirkbeck:divisiorsAntidiagonal_equiv
Closed

[Merged by Bors] - feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence.#27837
CBirkbeck wants to merge 14 commits intoleanprover-community:masterfrom
CBirkbeck:divisiorsAntidiagonal_equiv

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck commented Aug 1, 2025

Open in Gitpod

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Aug 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 1, 2025 •
edited
Loading

PR summary fff1550ff0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.TsumDivsorsAntidiagonal (new file) 719

Declarations diff

+ divisorsAntidiagonalFactors
+ divisorsAntidiagonalFactors_eq
+ divisorsAntidiagonalFactors_one
+ sigmaAntidiagonalEquivProd
+ sigmaAntidiagonalEquivProd_symm_apply_fst
+ sigmaAntidiagonalEquivProd_symm_apply_snd

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Aug 1, 2025
Closed
Closed
tb65536
tb65536 reviewed Aug 9, 2025
View reviewed changes
Comment thread Mathlib/NumberTheory/Divisors.lean Outdated
tb65536
tb65536 reviewed Aug 9, 2025
View reviewed changes
Comment thread Mathlib/NumberTheory/Divisors.lean Outdated
tb65536
tb65536 reviewed Aug 9, 2025
View reviewed changes
Comment thread Mathlib/NumberTheory/Divisors.lean Outdated
tb65536
tb65536 reviewed Aug 9, 2025
View reviewed changes
Comment thread Mathlib/NumberTheory/Divisors.lean Outdated
@tb65536 tb65536 added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 9, 2025
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 11, 2025
tb65536
tb65536 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer delegate

Comment thread Mathlib/NumberTheory/Divisors.lean Outdated
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 11, 2025

🚀 Pull request has been placed on the maintainer queue by tb65536.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 11, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Aug 13, 2025

Can you add a (very) basic API?

@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

CBirkbeck commented Aug 18, 2025

Sure I've added some basic stuff for now. But if you see anything else I should add let me know.

@CBirkbeck CBirkbeck mentioned this pull request Aug 20, 2025
Closed
1 task
@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

CBirkbeck commented Aug 20, 2025

Ok I moved this into a new file and you can see where this is going to be used in #28690

@riccardobrasca
Copy link
Copy Markdown
Member

riccardobrasca commented Aug 21, 2025

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 21, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 21, 2025
@CBirkbeck
feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence. (#2…
d940994 
…7837)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence. [Merged by Bors] - feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence. Aug 21, 2025
@mathlib-bors mathlib-bors bot closed this Aug 21, 2025
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
@CBirkbeck @Paul-Lez
feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence. (le…
3b50a83 
…anprover-community#27837)
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
@CBirkbeck @pechersky
feat(NumberTheory/Divisors): add divisorAntidiagonal equivalence. (le…
921fc77 
…anprover-community#27837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tb65536 tb65536 tb65536 approved these changes

Assignees

@tb65536 tb65536

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CBirkbeck @riccardobrasca @tb65536
⚡